divijvaidya commented on code in PR #13627:
URL: https://github.com/apache/kafka/pull/13627#discussion_r1176249165
##########
clients/src/main/java/org/apache/kafka/common/Uuid.java:
##########
@@ -143,12 +143,6 @@ public int compareTo(Uuid other) {
return 1;
Review Comment:
Can we use `Long.compare()` for mostSignificantBits as well?
##########
.gitignore:
##########
@@ -35,6 +35,7 @@ Vagrantfile.local
config/server-*
config/zookeeper-*
core/data/*
+core/data2/*
Review Comment:
perhaps add a note that this is created by a test [1], other wise other
reviewers may wonder (like me) as to where is this directory coming from
https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala#L2673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
