mumrah commented on code in PR #13631:
URL: https://github.com/apache/kafka/pull/13631#discussion_r1176825739
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumFeatures.java:
##########
@@ -128,4 +128,27 @@ VersionRange localSupportedFeature(String featureName) {
boolean isControllerId(int nodeId) {
return quorumNodeIds.contains(nodeId);
}
+
+ // check if all controller nodes are ZK Migration ready
+ public boolean isAllControllersZkMigrationReady() {
Review Comment:
Can we follow the same pattern that we've got in `reasonNotSupported` where
we return an optional string of a reason why the quorum isn't ready? That way
we can have all the pertinent logging come from KRaftMigrationDriver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
