mumrah commented on PR #13647: URL: https://github.com/apache/kafka/pull/13647#issuecomment-1525728492
Ah, looks like I introduced this problem. You're correct that we shouldn't call the fault handler here for expected errors like a controller failover. I added this logic to catch other errors inside the activation event regarding migration state. For example, if an established KRaft cluster is restarted with migrations enabled, we should terminate the controller with an error. Since we actually need to read some state from the metadata log to determine this, we can't just do a simple config validation as we start ControllerServer. Can we keep the exception handler, but only call the fault handler for RuntimeExceptions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
