cmccabe commented on code in PR #13651:
URL: https://github.com/apache/kafka/pull/13651#discussion_r1179715217
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -1275,12 +1271,21 @@ public static List<ApiMessageAndVersion>
generateActivationRecords(
}
return records;
}
+
class CompleteActivationEvent implements ControllerWriteOperation<Void> {
@Override
public ControllerResult<Void> generateRecordsAndResult() {
- List<ApiMessageAndVersion> records =
generateActivationRecords(log, logReplayTracker.empty(),
- zkMigrationEnabled, bootstrapMetadata, featureControl);
- return ControllerResult.atomicOf(records, null);
+ try {
+ List<ApiMessageAndVersion> records =
generateActivationRecords(log,
+ logReplayTracker.empty(),
+ zkMigrationEnabled,
+ bootstrapMetadata,
+ featureControl);
+ return ControllerResult.atomicOf(records, null);
+ } catch (Throwable t) {
+ throw fatalFaultHandler.handleFault("exception while
completing controller " +
Review Comment:
Yes, it's OK to halt from an event (or more generally to invoke fault
handlers from that context)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
