kirktrue commented on code in PR #13617: URL: https://github.com/apache/kafka/pull/13617#discussion_r1180727333
########## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ########## @@ -1635,7 +1636,7 @@ private enum ImbalanceSchedule { /** * Tracks if a snapshot generate was scheduled. */ - private boolean generateSnapshotScheduled = false; + private final boolean generateSnapshotScheduled; Review Comment: If the value is always set to `false`, why have the variable at all? 🤔 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org