kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1180888455


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -384,14 +436,19 @@ synchronized boolean isAborting() {
     }
 
     synchronized void transitionToAbortableError(RuntimeException exception) {

Review Comment:
   It's only used in `TransactionManagerTest`. I didn't want to expose the 
`InvalidStateTransitionHandler` quirkiness the outside world (even the tests).
   
   I went back and forth on this decision more than a couple of times. I'd 
certainly welcome your input.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to