dajac commented on code in PR #13659:
URL: https://github.com/apache/kafka/pull/13659#discussion_r1182960724


##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java:
##########
@@ -39,11 +39,13 @@
  * as the group coordinator. The coordinator selects one member to perform the 
group assignment and
  * propagates the subscriptions of all members to it. Then {@link 
#assign(Cluster, GroupSubscription)} is called
  * to perform the assignment and the results are forwarded back to each 
respective members
- *
+ * <p>
  * In some cases, it is useful to forward additional metadata to the assignor 
in order to make
  * assignment decisions. For this, you can override {@link 
#subscriptionUserData(Set)} and provide custom
  * userData in the returned Subscription. For example, to have a rack-aware 
assignor, an implementation
  * can use this user data to forward the rackId belonging to each member.
+ * <p>
+ * the implementation can extend {@link Configurable} to get configs from 
consumer.

Review Comment:
   nit: `The implementation...`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to