divijvaidya opened a new pull request, #13672:
URL: https://github.com/apache/kafka/pull/13672

   # Motivation
   PlaintextAdminIntegrationTest fails in a flaky manner with the follow trace 
(e.g. in [this 
build](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13670/3/tests/)):
   ```
   org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
        at 
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
        at 
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
        at org.junit.jupiter.api.AssertFalse.failNotFalse(AssertFalse.java:63)
        at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:36)
        at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:31)
        at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:228)
        at 
kafka.api.PlaintextAdminIntegrationTest.testElectUncleanLeadersForOnePartition(PlaintextAdminIntegrationTest.scala:1583)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   ```
   The std output doesn't contain useful information that we could use to debug 
the cause of failure. This is because the test, currently, validates if there 
is an exception and fails when one is present. It does not print what the 
exception is.
   
   # Change
   1. Make the test a bit more robust by waiting for server startup.
   2. Fail the test with the actual unexpected exception which will help in 
debugging the cause of failure.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to