vamossagar12 commented on code in PR #11433: URL: https://github.com/apache/kafka/pull/11433#discussion_r1185978385
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ########## @@ -342,7 +342,19 @@ public void handleAssignment(final Map<TaskId, Set<TopicPartition>> activeTasks, maybeThrowTaskExceptions(taskCloseExceptions); - createNewTasks(activeTasksToCreate, standbyTasksToCreate); + rebalanceInProgress = true; + final Collection<Task> newActiveTasks = createNewTasks(activeTasksToCreate, standbyTasksToCreate); + // If there are any transactions in flight and there are newly created active tasks, commit the tasks + // to avoid potential long restoration times. + if (processingMode == EXACTLY_ONCE_V2 && threadProducer().transactionInFlight() && !newActiveTasks.isEmpty()) { + log.info("New active tasks were added and there is an inflight transaction. Attempting to commit tasks."); + final int numCommitted = commitTasksAndMaybeUpdateCommittableOffsets(tasks.allTasks(), new HashMap<>()); Review Comment: Thanks @lucasbru. Are you suggesting that with new state-updated core, we won't get the problems which this PR is trying to solve? I am not aware of the the new state updater code path TBH. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org