splett2 commented on code in PR #13707: URL: https://github.com/apache/kafka/pull/13707#discussion_r1191586683
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -1956,10 +1956,10 @@ class KafkaConfig private(doLog: Boolean, val props: java.util.Map[_, _], dynami val transactionTopicSegmentBytes = getInt(KafkaConfig.TransactionsTopicSegmentBytesProp) val transactionAbortTimedOutTransactionCleanupIntervalMs = getInt(KafkaConfig.TransactionsAbortTimedOutTransactionCleanupIntervalMsProp) val transactionRemoveExpiredTransactionalIdCleanupIntervalMs = getInt(KafkaConfig.TransactionsRemoveExpiredTransactionalIdCleanupIntervalMsProp) - + val transactionPartitionVerificationEnable = getBoolean(KafkaConfig.TransactionPartitionVerificationEnableProp) - val producerIdExpirationMs = getInt(KafkaConfig.ProducerIdExpirationMsProp) + def producerIdExpirationMs = getInt(KafkaConfig.ProducerIdExpirationMsProp) Review Comment: This is a good question. It is probably worth making sure we have similar coverage for other dynamic broker configs. Looking at some other dynamic configs, eg: `LogCleanerThreadsProp`, I would expect them to run into similar issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
