AmareshB commented on code in PR #6247:
URL: https://github.com/apache/kafka/pull/6247#discussion_r1197203647
##########
clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java:
##########
@@ -388,6 +388,48 @@ public AlterConfigsResult alterConfigs(Map<ConfigResource,
Config> configs) {
*/
public abstract AlterConfigsResult alterConfigs(Map<ConfigResource,
Config> configs, AlterConfigsOptions options);
+ /**
+ * Incrementally updates the configuration for the specified resources
with default options.
+ *
+ * This is a convenience method for #{@link
AdminClient#incrementalAlterConfigs(Map, IncrementalAlterConfigsOptions)} with
default options.
+ * See the overload for more details.*
+ *
+ * This operation is supported by brokers with version 2.3.0 or higher.
+ *
+ * @param configs The resources with their configs
+ * @return The IncrementalAlterConfigsResult
+ */
+ public IncrementalAlterConfigsResult
incrementalAlterConfigs(Map<ConfigResource, Collection<AlterConfigOp>> configs)
{
+ return incrementalAlterConfigs(configs, new
IncrementalAlterConfigsOptions());
+ }
+
+
+ /**
+ * Incrementally update the configuration for the specified resources.
+ *
+ * Updates are not transactional so they may succeed for some resources
while fail for others. The configs for
Review Comment:
KIP mentions this is `transactional functionality` but the code here says
the opposite. Can you please clarify ?
From the KIP in proposed changes section - Similar to existing alterConfigs
API, we will to keep the "transactionality" of updating several configs for
the same ConfigResource at once. We guarantee that we never do a partial update
of a collection of configs
for a ConfigResource from a single request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
