divijvaidya commented on PR #13662: URL: https://github.com/apache/kafka/pull/13662#issuecomment-1554532930
Breaking changes between 2.13.x and 2.15.x: 1. `@JsonIgnore` gets more precedence than `@JsonProperty` in 2.15.x in case both annotations are assigned to a property. Prior to 2.14.x, it was the opposite precedence. See: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.14#observedreported-changes This should not impact Kafka since I couldn't find usages of `@JsonIgnore` in the code base. 2. ProcessingLimits adds limitation to length of different tokens. Prior to 2.15.x, there was no limits. See: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15#processing-limits Verified that `FileBasedStateStore` is not impacted by the new limits. 3. Modified handling of datetime with zone information in it. See: https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.15#changes-behavior-other @bmscomp could you please go through the usage of Jackson in Kafka code base and add here (similar to above) on why the new processing limits won't impact existing code (or comment if we want to increase the limits from default values). Same for ZoneId handling. Given the number of breaking changes, I think we should also create a JIRA for this (and associate the PR). This is not a minor change! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
