[GitHub] [kafka] C0urante commented on a diff in pull request #13776: KAFKA-15034: Improve performance of the ReplaceField SMT; add JMH benchmark

[via GitHub]

C0urante commented on code in PR #13776:
URL: https://github.com/apache/kafka/pull/13776#discussion_r1212108143


##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/ReplaceField.java:
##########
@@ -94,8 +96,8 @@ public void configure(Map<String, ?> configs) {
             {ConfigName.EXCLUDE, "blacklist"},
         }));
 
-        exclude = config.getList(ConfigName.EXCLUDE);
-        include = config.getList(ConfigName.INCLUDE);
+        exclude = new HashSet<>(config.getList(ConfigName.EXCLUDE));
+        include = new HashSet<>(config.getList(ConfigName.INCLUDE));

Review Comment:
   Can't argue with the numbers. Thanks for looking into this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org