jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1218084219
##########
core/src/main/scala/kafka/cluster/Partition.scala:
##########
@@ -1091,8 +1091,10 @@ class Partition(val topicPartition: TopicPartition,
// Note here we are using the "maximal", see explanation above
val replicaState = replica.stateSnapshot
if (replicaState.logEndOffsetMetadata.messageOffset <
newHighWatermark.messageOffset &&
- (replicaState.isCaughtUp(leaderLogEndOffset.messageOffset,
currentTimeMs, replicaLagTimeMaxMs)
- || partitionState.maximalIsr.contains(replica.brokerId))) {
+ ((replicaState.isCaughtUp(leaderLogEndOffset.messageOffset,
currentTimeMs, replicaLagTimeMaxMs) &&
+ isReplicaIsrEligible(replica.brokerId)) ||
Review Comment:
I agree. I called it `shouldWaitForReplica` since I think this is what the
leader is trying to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
