divijvaidya commented on code in PR #13814:
URL: https://github.com/apache/kafka/pull/13814#discussion_r1221588110
##########
clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java:
##########
@@ -269,7 +269,7 @@ public int partitionLeaderEpoch() {
public InputStream recordInputStream(BufferSupplier bufferSupplier) {
final ByteBuffer buffer = this.buffer.duplicate();
- buffer.position(RECORDS_OFFSET);
+ buffer.position(buffer.position() + RECORDS_OFFSET);
Review Comment:
not a relates change but something I found while lurking in the code. I
would probably revert it from this pr so that we don't pollute this with
unnecessary changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
