dajac commented on code in PR #13848:
URL: https://github.com/apache/kafka/pull/13848#discussion_r1227742933
##########
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##########
@@ -150,12 +150,8 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
listenerName: ListenerName = listenerName,
adminClientConfig: Properties = new Properties
): Unit = {
- if (isKRaftTest()) {
- resource(createAdminClient(brokers, listenerName, adminClientConfig)) {
admin =>
- TestUtils.createOffsetsTopicWithAdmin(admin, brokers)
- }
- } else {
- TestUtils.createOffsetsTopic(zkClient, servers)
Review Comment:
Is there a reason why we kept using the zk client here? It seems much better
to use the admin client all the time unless explicitly stated otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
