[ 
https://issues.apache.org/jira/browse/KAFKA-15085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732824#comment-17732824
 ] 

Owen C.H. Leung commented on KAFKA-15085:
-----------------------------------------

Hi [~divijvaidya] , can you assign this issue to me ? I'm eager to pick this up.

 

Also, can I ask if you can help to review my PR which aims to solve KAFKA-14712 
? 

https://github.com/apache/kafka/pull/13773

> Make Timer.java implement AutoCloseable
> ---------------------------------------
>
>                 Key: KAFKA-15085
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15085
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Divij Vaidya
>            Priority: Minor
>              Labels: Newbie, newbie
>
> Many automatic bug finders will flag a warning if an object of class which is 
> marked as AutoCloseable but is not closed properly in the code. Hence, as a 
> best practice we should implement AutoCloseable for classes which require 
> resources to be released after shutdown.
> Timer.java should implement AutoCloseable and ShutDown should be replaced 
> with close() method.
> Note that this interface change does not require a KIP since Timer.java is 
> not a user facing public class.
> This was discussed here: 
> [https://github.com/apache/kafka/pull/13820#discussion_r1222654614] 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to