machi1990 commented on code in PR #13665:
URL: https://github.com/apache/kafka/pull/13665#discussion_r1230920423
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##########
@@ -3818,13 +3899,16 @@ private void gracefulCloseTest(ConsumerCoordinator
coordinator, boolean shouldLe
return commitRequest.data().groupId().equals(groupId);
}, new OffsetCommitResponse(new OffsetCommitResponseData()));
+ // add t1p to the committed offset metadata cache, we'll then check
that the cache is invalidated after revocation which happens during close
+ coordinator.committedOffsetsCache().put(t1p, new
OffsetAndMetadata(1L));
Review Comment:
Thanks for pointing this out. I was thinking along the same lines as well
but I thought the `close()` case would have covered everything. I ended up
taking your suggestion and added a verification in the `testRejoinGroup`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
