maniekes commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1594625896
ok, good catch with MSYS2 @divijvaidya. i have installed git bash, msys2, cygwin and tested on all of them(on msys2 i testes on msys2-mingw and on pure msys2). what i noticed that msys2 was not reading paths properly because path translator for cygwin was adding backslashes instead of slashes (option --mixed vs --windows in cygpath, see my last commit). with option --windows it works on all those environments (hope you test is also in pipeline for cygwin to be double sure) ## Git bash ```bash vakom@rafal-laptok MINGW64 /c/rafal/git/maniekes-kafka (trunk) $ uname -a MINGW64_NT-10.0-22621 rafal-laptok 3.3.6-341.x86_64 2022-09-05 20:28 UTC x86_64 Msys vakom@rafal-laptok MINGW64 /c/rafal/git/maniekes-kafka (trunk) $ ./bin/kafka-server-start.sh config/server.properties SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/tools/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/trogdor/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/runtime/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/mirror/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] [2023-06-16 14:35:28,564] INFO Registered kafka:type=kafka.Log4jController MBean (kafka.utils.Log4jControllerRegistration$) [2023-06-16 14:35:28,713] INFO Setting -D jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS renegotiation (org.apache.zookeeper.common.X509Util) [2023-06-16 14:35:28,774] INFO starting (kafka.server.KafkaServer) [2023-06-16 14:35:28,775] INFO Connecting to zookeeper on localhost:2181 (kafka.server.KafkaServer) [2023-06-16 14:35:28,783] INFO [ZooKeeperClient Kafka server] Initializing a new session to localhost:2181. (kafka.zookeeper.ZooKeeperClient) [2023-06-16 14:35:28,806] INFO Client environment:zookeeper.version=3.6.4--d65253dcf68e9097c6e95a126463fd5fdeb4521c, built on 12/18/2022 18:10 GMT (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:35:28,806] INFO Client environment:host.name=192.168.1.137 (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:35:28,806] INFO Client environment:java.version=19.0.1 (org.apache.zookeeper.ZooKeeper) ... (skipped rest of logs because all looks fine) ``` ## MSYS2 ```bash vakom@rafal-laptok MSYS /c/rafal/git/maniekes-kafka $ uname -a MSYS_NT-10.0-22621 rafal-laptok 3.4.6.x86_64 2023-04-01 11:43 UTC x86_64 Msys vakom@rafal-laptok MSYS /c/rafal/git/maniekes-kafka $ ./bin/kafka-server-start.sh config/server.properties SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/tools/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/trogdor/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/runtime/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/mirror/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] log4j:WARN No appenders could be found for logger (kafka.utils.Log4jControllerRegistration$). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. (this is all) ``` **one remark**: in MSYS2 SLF4J is not printing logs, only warning that log appender cannot be found. however directories for kafka are being created properly and cluster works fine: ```bash vakom@rafal-laptok MSYS /c/rafal/git/maniekes-kafka $ ls -lart /c/tmp/kafka-logs/ razem 7 drwxr-xr-x 1 vakom vakom 0 06-16 14:41 .. -rw-r--r-- 1 vakom vakom 0 06-16 14:41 .lock -rw-r--r-- 1 vakom vakom 0 06-16 14:41 cleaner-offset-checkpoint -rw-r--r-- 1 vakom vakom 0 06-16 14:41 replication-offset-checkpoint -rw-r--r-- 1 vakom vakom 94 06-16 14:41 meta.properties -rw-r--r-- 1 vakom vakom 6 06-16 14:42 recovery-point-offset-checkpoint -rw-r--r-- 1 vakom vakom 6 06-16 14:42 log-start-offset-checkpoint -rw-r--r-- 1 vakom vakom 0 06-16 14:42 .kafka_cleanshutdown drwxr-xr-x 1 vakom vakom 0 06-16 14:42 . ``` ## MSYS2 MINGW64 ```bash vakom@rafal-laptok MINGW64 /c/rafal/git/maniekes-kafka $ uname -a MINGW64_NT-10.0-22621 rafal-laptok 3.4.6.x86_64 2023-04-01 11:43 UTC x86_64 Msys vakom@rafal-laptok MINGW64 /c/rafal/git/maniekes-kafka $ ./bin/kafka-server-start.sh config/server.properties SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/tools/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/trogdor/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/runtime/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/mirror/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] log4j:WARN No appenders could be found for logger (kafka.utils.Log4jControllerRegistration$). log4j:WARN Please initialize the log4j system properly. log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info. (this is all) ``` **remark**: same as for pure MSYS2 ## CYGWIN ```bash vakom@rafal-laptok /cygdrive/c/rafal/git/maniekes-kafka $ uname -a CYGWIN_NT-10.0-22621 rafal-laptok 3.4.6-1.x86_64 2023-02-14 13:23 UTC x86_64 Cygwin vakom@rafal-laptok /cygdrive/c/rafal/git/maniekes-kafka $ ./bin/kafka-server-start.sh config/server.properties SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/tools/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/trogdor/build/dependant-libs-2.13.10/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/runtime/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/C:/rafal/git/maniekes-kafka/connect/mirror/build/dependant-libs/slf4j-reload4j-1.7.36.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Reload4jLoggerFactory] [2023-06-16 14:45:56,260] INFO Registered kafka:type=kafka.Log4jController MBean (kafka.utils.Log4jControllerRegistration$) [2023-06-16 14:45:56,415] INFO Setting -D jdk.tls.rejectClientInitiatedRenegotiation=true to disable client-initiated TLS renegotiation (org.apache.zookeeper.common.X509Util) [2023-06-16 14:45:56,484] INFO starting (kafka.server.KafkaServer) [2023-06-16 14:45:56,485] INFO Connecting to zookeeper on localhost:2181 (kafka.server.KafkaServer) [2023-06-16 14:45:56,497] INFO [ZooKeeperClient Kafka server] Initializing a new session to localhost:2181. (kafka.zookeeper.ZooKeeperClient) [2023-06-16 14:45:56,520] INFO Client environment:zookeeper.version=3.6.4--d65253dcf68e9097c6e95a126463fd5fdeb4521c, built on 12/18/2022 18:10 GMT (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:45:56,520] INFO Client environment:host.name=192.168.1.137 (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:45:56,520] INFO Client environment:java.version=19.0.1 (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:45:56,520] INFO Client environment:java.vendor=Oracle Corporation (org.apache.zookeeper.ZooKeeper) [2023-06-16 14:45:56,520] INFO Client environment:java.home=C:\Program Files\java\jdk-19.0.1 (org.apache.zookeeper.ZooKeeper) ... (skipped rest of logs because all looks fine) ``` i hope this is ok for your sanity tests. regarding MSYS2, i think since cluster works fine and we are supporting it only occasionally it is ok to leave it like this? (without those changes it wont work at all in MSYS2 anyway...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
