hudeqi commented on PR #13839:
URL: https://github.com/apache/kafka/pull/13839#issuecomment-1594953593

   
   
   
   > Thanks for the PR @hudeqi. I think it's always good to improve JavaDocs or 
ScalaDocs.
   > 
   > I was looking at the `LogCleaner.scala` file and I saw there are plenty of 
methods that are public which have only a very general documentation and they 
don't have any parameter annotation with documentation. For example 
`abortCleaning` in line 220 and some of the following methods.
   > 
   > For the sake of completion, would you be up to adding the missing 
annotations to the methods that are public? Extra mile for all the ones that 
are package-log-protected (`private[log]`)
   
   Hi, thanks for the comments, I have added the comments of the methods you 
mentioned, please help to review, thank you! @jlprat 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to