divijvaidya commented on code in PR #13868:
URL: https://github.com/apache/kafka/pull/13868#discussion_r1233774289
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -342,9 +347,7 @@ class ReplicaManagerTest {
rm.becomeLeaderOrFollower(1, leaderAndIsrRequest2, (_, _) => ())
assertTrue(appendResult.hasFired)
- } finally {
- rm.shutdown(checkpointHW = false)
- }
+ } finally rm.shutdown(checkpointHW = false)
Review Comment:
The test right now is a mix (even without my change). I have made it
consistent now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
