C0urante commented on code in PR #13885:
URL: https://github.com/apache/kafka/pull/13885#discussion_r1235437562
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState>
stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState>
stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -325,20 +325,20 @@ public boolean awaitShutdown(long timeoutMs) {
}
public void transitionTo(TargetState targetState, Callback<TargetState>
stateChangeCallback) {
- Callback<TargetState> preEmptedStateChangeCallback;
- TargetState preEmptedState;
+ Callback<TargetState> preEmptiedStateChangeCallback;
+ TargetState preEmptiedState;
synchronized (this) {
- preEmptedStateChangeCallback =
pendingStateChangeCallback.getAndSet(stateChangeCallback);
- preEmptedState = pendingTargetStateChange.getAndSet(targetState);
+ preEmptiedStateChangeCallback =
pendingStateChangeCallback.getAndSet(stateChangeCallback);
+ preEmptiedState = pendingTargetStateChange.getAndSet(targetState);
notify();
}
- if (preEmptedStateChangeCallback != null) {
- preEmptedStateChangeCallback.onCompletion(
+ if (preEmptiedStateChangeCallback != null) {
+ preEmptiedStateChangeCallback.onCompletion(
new ConnectException(
- "Could not begin changing connector state to " +
preEmptedState.name()
+ "Could not begin changing connector state to " +
preEmptiedState.name()
+ " before another request to change state was
made;"
+ " the new request (which is to change the
state to " + targetState.name()
- + ") has pre-empted this one"),
+ + ") has pre-emptied this one"),
Review Comment:
Also incorrect
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConnector.java:
##########
@@ -271,12 +271,12 @@ public synchronized void shutdown() {
void doShutdown() {
try {
- TargetState preEmptedState =
pendingTargetStateChange.getAndSet(null);
+ TargetState preEmptiedState =
pendingTargetStateChange.getAndSet(null);
Review Comment:
This change is incorrect; "pre-empted" is the intended term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
