lmr3796 commented on code in PR #13187: URL: https://github.com/apache/kafka/pull/13187#discussion_r1235962927
########## core/src/main/scala/kafka/cluster/Partition.scala: ########## @@ -1046,10 +1046,14 @@ class Partition(val topicPartition: TopicPartition, partitionState match { case currentState: CommittedPartitionState if outOfSyncReplicaIds.nonEmpty => val outOfSyncReplicaLog = outOfSyncReplicaIds.map { replicaId => - val logEndOffsetMessage = getReplica(replicaId) - .map(_.stateSnapshot.logEndOffset.toString) + val replicaStateSnapshot = getReplica(replicaId).map(_.stateSnapshot) + val logEndOffsetMessage = replicaStateSnapshot + .map(_.logEndOffset.toString) .getOrElse("unknown") - s"(brokerId: $replicaId, endOffset: $logEndOffsetMessage)" + val lastCaughtUpTimeMessage = replicaStateSnapshot + .map(_.lastCaughtUpTimeMs.toString) + .getOrElse("unknown") + s"(brokerId: $replicaId, endOffset: $logEndOffsetMessage, lastCaughtUpTime: $lastCaughtUpTimeMessage)" Review Comment: Hi @divijvaidya thanks for the great idea. Just added the suffix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org