machi1990 commented on PR #13665: URL: https://github.com/apache/kafka/pull/13665#issuecomment-1600404343
> > offsets commits are happening somewhere else and that's via the producer.sendOffsetsToTransaction(..) e.g > > Oh, EOS case! I didn't consider it, sorry! Hmm... if there is EOS case to consider, the original cache mechanism will not work since the offset commit is not via consumer, the consumer has no idea which offset has committed. I think we should close this PR and JIRA ticket as "invalid" and add comment into the JIRA ticket. WDYT? Thanks @showuon I've marked the JIRA as invalid. As for the PR, I've repurposed it to only keep the things we can keep from this change. Please have a look when you can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
