jsancio commented on code in PR #13910: URL: https://github.com/apache/kafka/pull/13910#discussion_r1240397926
########## metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java: ########## @@ -207,7 +211,7 @@ public void testTriggerLeaderEpochBumpIfNeeded() { createFooBuilder() .setTargetIsrWithBrokerStates( AlterPartitionRequest.newIsrToSimpleNewIsrWithBrokerEpochs(Arrays.asList(2, 1, 3, 4))) - .setBumpLeaderEpochOnIsrShrink(true), + .enableBumpLeaderEpochOnIsrShrink(true), Review Comment: Hmm. Shouldn't this test fail? Let's add a comment explaining what this test is doing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org