ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242345211
########## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ########## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { // Skip bytes stored in intermediate buffer first int avail = count - pos; - long bytesSkipped = (avail < remaining) ? avail : remaining; + int bytesSkipped = Math.min(avail, (int) remaining); Review Comment: > behaviour is implementation defined Can you share a reference for this? My understanding is that the Java specifies the behavior in these cases. Perhaps you're thinking of a C or something like that? > let's say remaining = Integer.MIN_VALUE + 1000 I think you meant to say that if we have a `long` of value (Integer.MAX_VALUE + 1000) may result in sign extension during truncation resulting in a negative int. That's a fair point - my bad. I'll fix this. It does show a gap in the tests for this class, we should ideally have tests that cover these boundary cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org