jolshan commented on code in PR #13798:
URL: https://github.com/apache/kafka/pull/13798#discussion_r1242731206
##########
clients/src/main/java/org/apache/kafka/common/requests/AddPartitionsToTxnRequest.java:
##########
@@ -154,6 +154,11 @@ public AddPartitionsToTxnRequest normalizeRequest() {
return new AddPartitionsToTxnRequest(new
AddPartitionsToTxnRequestData().setTransactions(singletonTransaction()),
version());
}
+ public boolean verifyOnlyRequest() {
Review Comment:
I remember why I made this choice. We want all the requests to be verify
only because the idea is that verify only requests require in memory checks
only. Adding the partition otherwise requires a write to the log.
In the case that any partition needs to be added and not just verified, we
have that log write which will always take the majority of the time. In this
case, it makes sense to group with the normal add partitions requests. However,
in the case where all transactions are verify only, we will see faster handling
and therefore want to separate the requests to different metrics as to not
bring down the average for metrics like request timing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
