[GitHub] [kafka] hudeqi commented on a diff in pull request #13924: KAFKA-15129;[1/N] Remove metrics in LogCleanerManager when LogCleaner shutdown

[via GitHub]

hudeqi commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1247795935


##########
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##########
@@ -555,6 +568,17 @@ private case class OffsetsToClean(firstDirtyOffset: Long,
 }
 
 private[log] object LogCleanerManager extends Logging {
+  private val UncleanablePartitionsCountMetricName = 
"uncleanable-partitions-count"

Review Comment:
   > Is there a reason why decided to have these variable names start with a 
capital letter?
   
   https://github.com/apache/kafka/pull/13623#discussion_r1182593025



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org