yashmayya opened a new pull request, #13948: URL: https://github.com/apache/kafka/pull/13948
From https://issues.apache.org/jira/browse/KAFKA-15091: > The Javadocs for SourceTask::commit state that the method should: > > Commit the offsets, up to the offsets that have been returned by [poll()](https://kafka.apache.org/34/javadoc/org/apache/kafka/connect/source/SourceTask.html#poll()). > > However, this is obviously incorrect given how the Connect runtime (when not configured with exactly-once support for source connectors) performs polling and offset commits on separate threads. There's also some extensive discussion on the semantics of that method in [KAFKA-5716](https://issues.apache.org/jira/browse/KAFKA-5716) where it's made clear that altering the behavior of the runtime to align with the documented semantics of that method is not a viable option. > > We should update the Javadocs for this method to state that it does not have anything to do with the offsets returned from SourceTask:poll and is instead just a general, periodically-invoked hook to let the task know that an offset commit has taken place (but with no guarantees as to which offsets have been committed and which ones correspond to still-in-flight records). ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
