LinShunKang commented on PR #12685: URL: https://github.com/apache/kafka/pull/12685#issuecomment-1616603443
> > Add @deprecated annotation for Utils#murmur2(byte[]) > > We should anyways start using murmur3 starting Kafka 4.x. Also perhaps the endia-ness neutral version of it otherwise we risk having different architectures/clients sending partitions differently. If you are interested, a KIP would be required to move to murmur3 and with that KIP we can mark murmur2 completely deprecated. 1. When I add the @Deprecated annotation to Utils#murmur2(byte[]), the test cases will result in an error when executed. 2. I am interested in switching to murmur3, but the decision of whether to use a byte-order-independent algorithm may require further discussion. Considering that there are Kafka clients in languages other than Java, we need an algorithm that is independent of language and computer architecture. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
