cadonna commented on code in PR #13873:
URL: https://github.com/apache/kafka/pull/13873#discussion_r1250518557
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java:
##########
@@ -2469,19 +2416,18 @@ public void
shouldCloseStandbyUnassignedTasksWhenCreatingNewTasks() {
assertThat(task00.state(), is(Task.State.CLOSED));
assertThat(taskManager.activeTaskMap(), Matchers.anEmptyMap());
assertThat(taskManager.standbyTaskMap(), Matchers.anEmptyMap());
+ verifyResumeWasCalled(consumer);
Review Comment:
I understand what you mean regarding the verification. However, the original
author did not call `verify()` on the consumer. Therefore, I was wondering why
you added a verification. As I commented
[here](https://github.com/apache/kafka/pull/13873#discussion_r1242098191) I am
not sure if the original author just missed to add the `verify()`. So I am fine
with you adding the verification, I just was not sure if you had a reason that
I did not see.
Regarding inlining the verification, yes, I would be in favor of inlining.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
