divijvaidya commented on code in PR #13924:
URL: https://github.com/apache/kafka/pull/13924#discussion_r1251886768
##########
core/src/main/scala/kafka/log/LogCleanerManager.scala:
##########
@@ -555,6 +570,17 @@ private case class OffsetsToClean(firstDirtyOffset: Long,
}
private[log] object LogCleanerManager extends Logging {
+ private val UncleanablePartitionsCountMetricName =
"uncleanable-partitions-count"
+ private val UncleanableBytesMetricName = "uncleanable-bytes"
+ private val MaxDirtyPercentMetricName = "max-dirty-percent"
+ private val TimeSinceLastRunMsMetricName = "time-since-last-run-ms"
+
+ private[log] val GaugeMetricNameWithTag = new java.util.HashMap[String,
java.util.List[java.util.Map[String, String]]]()
Review Comment:
From https://kafka.apache.org/coding-guide:
`Constants should be camel case with an initial capital LikeThis not
LIKE_THIS.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
