[ https://issues.apache.org/jira/browse/KAFKA-6729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475285#comment-16475285 ]
ASF GitHub Bot commented on KAFKA-6729: --------------------------------------- guozhangwang opened a new pull request #5017: KAFKA-6729: Reuse source topics for source KTable's materialized store's changelog URL: https://github.com/apache/kafka/pull/5017 1. In InternalTopologyBuilder#topicGroups, which is used in StreamsPartitionAssignor, look for book-kept `storeToChangelogTopic` map before creating a new internal changelog topics. In this way if the source KTable is created, its source topic stored in `storeToChangelogTopic` will be used. 2. Added unit test (confirmed that without 1) it will fail). 3. MINOR: removed TODOs that are related to removed KStreamBuilder. 4. MINOR: removed TODOs in StreamsBuilderTest util functions and replaced with TopologyWrapper. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > KTable should use user source topics if possible and not create changelog > topic > ------------------------------------------------------------------------------- > > Key: KAFKA-6729 > URL: https://issues.apache.org/jira/browse/KAFKA-6729 > Project: Kafka > Issue Type: Bug > Components: streams > Affects Versions: 1.0.0 > Reporter: Matthias J. Sax > Assignee: Bill Bejeck > Priority: Blocker > Fix For: 2.0.0 > > > With KIP-182 we reworked Streams API largely and introduced a regression into > 1.0 code base. If a KTable is populated from a source topic, ie, > StreamsBuilder.table() -- the KTable does create its own changelog topic. > However, in older releases (0.11 or older), we don't create a changelog topic > but use the user specified source topic instead. > We want to reintroduce this optimization to reduce the load (storage and > write) on the broker side for this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)