[ 
https://issues.apache.org/jira/browse/KAFKA-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475751#comment-16475751
 ] 

Attila Sasvari commented on KAFKA-6884:
---------------------------------------

Thanks [~hachikuji]. I have seen the pull request was updated, so I also 
updated [my work in progress 
patch|https://github.com/asasvari/kafka/tree/KAFKA-6884_ConsumerGroupCommand_should_use_new_AdminClient]
 too.

Right now 9/31 tests fail in DescribeConsumerGroupTest: 
- Four of them are related to the change in behaviour of handling timeouts. In 
particual, now a ExecutionException is is thrown that carries the information. 
For example, {{testDescribeGroupOffsetsWithShortInitializationTimeout, 
testDescribeGroupMembersWithShortInitializationTimeout, 
testDescribeGroupStateWithShortInitializationTimeout, 
testDescribeGroupWithShortInitializationTimeout}} fail with:
{code}
java.util.concurrent.ExecutionException: 
org.apache.kafka.common.errors.TimeoutException: Timed out waiting for a node 
assignment.
{code}
(TimeoutException is embedded in ExecutionException)
- Rest of the failures are related to assignments / group membership. As I see 
handling assignment information of ConsumerGroupDescription in KafkaAdminClient 
is different from the previous version. If consumer group is not in state 
"Stable", an empty list is returned, see 
[AdminClient.scala|https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/admin/AdminClient.scala#L336].
 Because of the change, when state is unknown, KafkaAdminClient returns :
{code}
java.lang.AssertionError: Expected no active member in describe group results, 
state: Some(Unknown), assignments: 
Some(List(PartitionAssignmentState(test.group,Some(localhost:58637 (id: 0 rack: 
null)),Some(foo),Some(0),Some(0),Some(0),Some(-),Some(-),Some(-),Some(0))))

        at org.junit.Assert.fail(Assert.java:88)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at 
kafka.admin.DescribeConsumerGroupTest.testDescribeOffsetsOfExistingGroupWithNoMembers(DescribeConsumerGroupTest.scala:339)
...
{code}
I believe that is why  {{testDescribeExistingGroupWithNoMembers, 
testDescribeOffsetsOfExistingGroupWithNoMembers, 
testDescribeSimpleConsumerGroup, 
testDescribeMembersOfExistingGroupWithNoMembers, 
testDescribeStateOfExistingGroupWithNoMembers}} fail, but I am still 
investigating.

> ConsumerGroupCommand should use new AdminClient
> -----------------------------------------------
>
>                 Key: KAFKA-6884
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6884
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jason Gustafson
>            Assignee: Attila Sasvari
>            Priority: Major
>
> Now that we have KIP-222, we should update consumer-groups.sh to use the new 
> AdminClient.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to