gharris1727 commented on code in PR #13821:
URL: https://github.com/apache/kafka/pull/13821#discussion_r1253768895
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java:
##########
@@ -104,6 +81,33 @@ public DelegatingClassLoader(List<Path> pluginLocations) {
this(pluginLocations, DelegatingClassLoader.class.getClassLoader());
}
+ public Set<PluginSource> sources() {
Review Comment:
> I think it's fine in PluginUtils if we plan on using it in multiple places.
Right now it's used in Plugins (main) and DelegatingClassLoaderTest (test).
This will be used in the manifest generation script (main), without the
surrounding `Plugins`, so i'll leave it as-is.
I've made the other changes you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
