[ 
https://issues.apache.org/jira/browse/KAFKA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740890#comment-17740890
 ] 

Jorge Esteban Quilcate Otoya commented on KAFKA-15158:
------------------------------------------------------

Thanks [~divijvaidya] , this cover most of the metrics proposed here 
https://issues.apache.org/jira/browse/KAFKA-14953 on the latest comments.

Could we also consider adding `RemoteDeleteErrorPerSec` here?

About discussing the naming issues with `RemoteBytesIn|Out` I can create a new 
ticket to discuss it. wdyt?

> Add metrics for RemoteRequestsPerSec
> ------------------------------------
>
>                 Key: KAFKA-15158
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15158
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Divij Vaidya
>            Priority: Major
>             Fix For: 3.6.0
>
>
> Add the following metrics for better observability into the RemoteLog related 
> activities inside the broker.
> 1. RemoteWriteRequestsPerSec
> 2. RemoteDeleteRequestsPerSec
> 3. BuildRemoteLogAuxStateRequestsPerSec
>  
> These metrics will be calculated at topic level (we can add them at 
> brokerTopicStats)
> *RemoteWriteRequestsPerSec* will be marked on every call to RemoteLogManager#
> copyLogSegmentsToRemote()
>  
> *RemoteDeleteRequestsPerSec* will be marked on every call to 
> RemoteLogManager#cleanupExpiredRemoteLogSegments(). This method is introduced 
> in [https://github.com/apache/kafka/pull/13561] 
> *BuildRemoteLogAuxStateRequestsPerSec* will be marked on every call to 
> ReplicaFetcherTierStateMachine#buildRemoteLogAuxState()
>  
>  
> (Note that this requires a change in KIP-405 and hence, must be approved by 
> KIP author [~satishd] )
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to