satishd commented on code in PR #13936:
URL: https://github.com/apache/kafka/pull/13936#discussion_r1255603306
##########
core/src/main/scala/kafka/log/remote/RemoteIndexCache.scala:
##########
@@ -38,7 +38,60 @@ import java.util.concurrent.locks.ReentrantReadWriteLock
object RemoteIndexCache {
val DirName = "remote-log-index-cache"
val TmpFileSuffix = ".tmp"
- val remoteLogIndexCacheCleanerThread = "remote-log-index-cleaner"
+ val RemoteLogIndexCacheCleanerThread = "remote-log-index-cleaner"
+
+ def RemoteLogSegmentIdFromRemoteIndexFileName(fileName: String): Uuid = {
Review Comment:
It looks like we do not use `PascalCase or CamelCase` for methods in object
class. Should we continue using `camelCase` here like in other places in this
project?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
