abhijeetk88 commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1257264600
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java:
##########
@@ -41,6 +44,19 @@ public String logPrefix() {
return "[" + Thread.currentThread().getName() + "]";
}
}.logger(RemoteStorageThreadPool.class);
+ KafkaMetricsGroup metricsGroup = new
KafkaMetricsGroup(this.getClass());
+ metricsGroup.newGauge(metricsNamePrefix.concat("TaskQueueSize"), new
Gauge<Integer>() {
+ @Override
+ public Integer value() {
+ return RemoteStorageThreadPool.this.getQueue().size();
Review Comment:
Do we need that kind of accuracy for this metric? A bit of staleness should
be okay, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
