ivanyu commented on code in PR #13984:
URL: https://github.com/apache/kafka/pull/13984#discussion_r1258358905
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -239,96 +240,186 @@ void testStartup() {
assertEquals(logDir, capture.getValue().get("log.dir"));
}
- // This test creates 2 log segments, 1st one has start offset of 0, 2nd
one (and active one) has start offset of 150.
Review Comment:
To make the review easier: in this test file,
- `testCopyLogSegmentsToRemoteShouldCopyExpectedLogSegment` was moved to a
test subclass;
- The code that initializes the log mock was extracted to `setUp`;
- A new test `testCustomMetadataSizeExceedsLimit` was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
