eziosudo commented on PR #13973:
URL: https://github.com/apache/kafka/pull/13973#issuecomment-1631271129

   > Thank you for addressing the comments. Are the results in the description 
updated after the latest change? If not, can you please update them. My 
motivation of asking this is to ensure that we are not accidentally removing 
the tests from running in either unitTest or integTests.
   
   I agree. We shall be careful with every merge. So I run all the tests agian.
   
   These are integration tests in trunk branch after running './gradlew 
unitTest':
   <img width="1130" alt="image" 
src="https://github.com/apache/kafka/assets/54128896/80ea1f96-9aea-4779-a77a-3790a570889b";>
   
   In my branch I run './gradlew unitTest' then filter integration tests and 
got nothing, which means integration cases are excluded.
   <img width="651" alt="image" 
src="https://github.com/apache/kafka/assets/54128896/6c4d632a-cc90-4937-ba0a-fb1ea116259a";>
   
   After run './gradle integrationTest' in my branch, I get all the integration 
tests I changed in this PR, which means they are all included.
   <img width="1183" alt="image" 
src="https://github.com/apache/kafka/assets/54128896/56837acc-999d-4c34-8ee2-9fc1d1636b77";>
   <img width="1045" alt="image" 
src="https://github.com/apache/kafka/assets/54128896/73e98e5d-0aaa-4ca7-af93-2398eb00181b";>
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to