divijvaidya commented on code in PR #13956:
URL: https://github.com/apache/kafka/pull/13956#discussion_r1261325930
##########
core/src/test/scala/integration/kafka/api/AbstractConsumerTest.scala:
##########
@@ -346,6 +346,7 @@ abstract class AbstractConsumerTest extends BaseRequestTest
{
partitionsToAssign:
Set[TopicPartition],
userRebalanceListener:
ConsumerRebalanceListener)
extends ShutdownableThread("daemon-consumer-assignment", false) {
+ setDaemon(true)
Review Comment:
I added this as a fail safe but yes, it's not required if we close them
properly. I have reverted them back in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
