satishd commented on code in PR #13944:
URL: https://github.com/apache/kafka/pull/13944#discussion_r1262221260
##########
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##########
@@ -277,6 +277,12 @@ class BrokerTopicMetrics(name: Option[String]) {
BrokerTopicStats.TotalFetchRequestsPerSec ->
MeterWrapper(BrokerTopicStats.TotalFetchRequestsPerSec, "requests"),
BrokerTopicStats.FetchMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.FetchMessageConversionsPerSec, "requests"),
BrokerTopicStats.ProduceMessageConversionsPerSec ->
MeterWrapper(BrokerTopicStats.ProduceMessageConversionsPerSec, "requests"),
+ BrokerTopicStats.RemoteCopyBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteCopyBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteFetchBytesPerSec ->
MeterWrapper(BrokerTopicStats.RemoteFetchBytesPerSec, "bytes"),
+ BrokerTopicStats.RemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.RemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.RemoteWriteRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteReadRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteReadRequestsPerSec, "requests"),
+ BrokerTopicStats.FailedRemoteWriteRequestsPerSec ->
MeterWrapper(BrokerTopicStats.FailedRemoteWriteRequestsPerSec, "requests"),
Review Comment:
We should avoid having multiple versions of metrics here. As it is not yet
released in Apache, we should have better naming agreeable for the majority. We
do not need to have two versions here when it is released in Apache. It avoids
confusion for users too. We can discuss whether that can be done by updating
KIP-405(I guess I did update d a couple of them) or we can have a minor KIP for
them.
@divijvaidya This small change can be handled by organizations that adopted
KIP-405.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
