[GitHub] [kafka] C0urante commented on a diff in pull request #13977: KAFKA-15162: Reflectively find plugins in parent ClassLoaders that arent on the classpath

[via GitHub]

C0urante commented on code in PR #13977:
URL: https://github.com/apache/kafka/pull/13977#discussion_r1262939116


##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginsTest.java:
##########
@@ -500,6 +500,11 @@ private void assertClassLoaderReadsVersionFromResource(
         );
         plugins = new Plugins(pluginProps, parent, new ClassLoaderFactory());
 
+        assertTrue("Should find plugin in plugin classloader",
+                plugins.converters().stream().anyMatch(desc -> desc.loader() 
instanceof PluginClassLoader));
+        assertTrue("Should find plugin in parent classloader",
+                plugins.converters().stream().anyMatch(desc -> !(desc.loader() 
instanceof PluginClassLoader)));

Review Comment:
   Can we make this more explicit (especially since it would match the 
assertion message)?
   ```suggestion
                   plugins.converters().stream().anyMatch(desc -> 
parent.equals(desc.loader())));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org