fvaleri commented on PR #13562:
URL: https://github.com/apache/kafka/pull/13562#issuecomment-1635504373
Hi @ruslankrivoshein, thanks for adding the warning message.
Not sure if this is ready for another review, but I still see some issues.
The checkstyle phase is still failing, I suggested a way to fix it in one of
my previous comments.
I don't see the stacktrace anymore in case of wrong options, but the error
messages are not exactly the same as before. In general, we should match the
old behavior when reporting errors.
```sh
# before
$ bin/kafka-get-offsets.sh --topic my-topic --time -3
Error occurred: Missing required option(s) [bootstrap-server]
# now
$ bin/kafka-get-offsets.sh --topic my-topic --time -3
Missing required option(s) [bootstrap-server]
Option Description
------ -----------
--bootstrap-server <String: HOST1: REQUIRED. The server(s) to connect
to
PORT1,...,HOST3:PORT3> in the form
HOST1:PORT1,HOST2:PORT2.
--broker-list <String: HOST1:PORT1,..., DEPRECATED, use --bootstrap-server
HOST3:PORT3> instead; ignored if --bootstrap-
server is specified. The
server(s)
to connect to in the form HOST1:
PORT1,HOST2:PORT2.
...
# before
$ bin/kafka-get-offsets.sh --broker-list :9092 --topic __consumer_offsets
--time -1 --exclude-internal-topics
Error occurred: Could not match any topic-partitions with the specified
filters
# now
$ bin/kafka-get-offsets.sh --broker-list :9092 --topic __consumer_offsets
--time -1 --exclude-internal-topics
Could not match any topic-partitions with the specified filters
```
Finally, the `tests/kafkatest/tests/core/get_offset_shell_test.py` system
test fails because you need to also update the GetOffsetShell package in
`tests/kafkatest/services/kafka/kafka.py`. You can run this test like this:
```sh
./gradlew clean systemTestLibs
TC_PATHS="tests/kafkatest/tests/core/get_offset_shell_test.py" bash
tests/docker/run_tests.sh
```
Hope it helps.
Let me know when you are ready for another round of review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
