[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

[via GitHub]

jeffkbkim commented on code in PR #13870:
URL: https://github.com/apache/kafka/pull/13870#discussion_r1265574666


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java:
##########
@@ -561,7 +625,7 @@ public boolean hasReceivedSyncFromAllMembers() {
      * @return members that have yet to sync.
      */
     public Set<String> allPendingSyncMembers() {
-        return pendingSyncMembers;
+        return new HashSet<>(pendingSyncMembers);

Review Comment:
   thought i addressed this. addressed it now



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org