showuon commented on code in PR #13999:
URL: https://github.com/apache/kafka/pull/13999#discussion_r1267657308
##########
core/src/main/java/kafka/log/remote/RemoteLogReader.java:
##########
@@ -31,14 +32,18 @@ public class RemoteLogReader implements Callable<Void> {
private final Logger logger;
private final RemoteStorageFetchInfo fetchInfo;
private final RemoteLogManager rlm;
+ private final BrokerTopicStats brokerTopicStats;
private final Consumer<RemoteLogReadResult> callback;
public RemoteLogReader(RemoteStorageFetchInfo fetchInfo,
RemoteLogManager rlm,
- Consumer<RemoteLogReadResult> callback) {
+ Consumer<RemoteLogReadResult> callback,
+ BrokerTopicStats brokerTopicStats) {
this.fetchInfo = fetchInfo;
this.rlm = rlm;
+ this.brokerTopicStats = brokerTopicStats;
this.callback = callback;
+
this.brokerTopicStats.topicStats(fetchInfo.topicPartition.topic()).remoteReadRequestRate().mark();
Review Comment:
This could be another improvement. I think this is out of the scope of this
PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
