rreddy-22 commented on code in PR #13998:
URL: https://github.com/apache/kafka/pull/13998#discussion_r1270002911
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##########
@@ -434,22 +437,36 @@ public void setSubscriptionMetadata(
public Map<String, TopicMetadata> computeSubscriptionMetadata(
ConsumerGroupMember oldMember,
ConsumerGroupMember newMember,
- TopicsImage topicsImage
+ TopicsImage topicsImage,
+ ClusterImage clusterImage
Review Comment:
Since metadataImage has a lot more images that we don't need and passing the
specific arguments makes it more readable, maintainable, and testable I feel
like we can keep it as two separate arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
