gharris1727 commented on PR #14089: URL: https://github.com/apache/kafka/pull/14089#issuecomment-1650218495
> should we expand the scope of how PluginDesc objects can be compared? Yes, this is a good idea. I could feel that something was wrong when I had to double-cast the dissimilar types in the comparison test, but at the time I didn't think of the signature change. I had to make one other adjustment in the PluginScanResult, and everything else lines up now. Thanks, this is ready for another pass! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
