dajac commented on code in PR #14017: URL: https://github.com/apache/kafka/pull/14017#discussion_r1273993761
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ########## @@ -330,9 +330,30 @@ public CompletableFuture<SyncGroupResponseData> syncGroup( return FutureUtils.failedFuture(Errors.COORDINATOR_NOT_AVAILABLE.exception()); } - return FutureUtils.failedFuture(Errors.UNSUPPORTED_VERSION.exception( - "This API is not implemented yet." - )); + if (!isGroupIdNotEmpty(request.groupId())) { + return CompletableFuture.completedFuture(new SyncGroupResponseData() + .setErrorCode(Errors.INVALID_GROUP_ID.code())); + } + + CompletableFuture<SyncGroupResponseData> responseFuture = new CompletableFuture<>(); + + runtime.scheduleWriteOperation("generic-group-sync", + topicPartitionFor(request.groupId()), + coordinator -> coordinator.genericGroupSync(context, request, responseFuture) + ).exceptionally(exception -> { + if (!(exception instanceof KafkaException)) { + log.error("Request {} hit an unexpected exception: {}", Review Comment: nit: `SyncGroup request`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org