[GitHub] [kafka] jolshan commented on a diff in pull request #14090: KAFKA-14048; CoordinatorContext should be protected by a lock

[via GitHub]

jolshan commented on code in PR #14090:
URL: https://github.com/apache/kafka/pull/14090#discussion_r1274094726


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##########
@@ -970,14 +970,15 @@ public void testClose() throws Exception {
         assertFalse(write2.isDone());
 
         // The coordinator timer should be empty.
-        assertEquals(0, ctx.timer.size());
+        CoordinatorRuntime.EventBasedCoordinatorTimer coordinatorTimer = 
ctx.timer;

Review Comment:
   Was this just a cleanup? (ie, the old code would work but this is cleaner?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org